With any product, there are those who swear by it and those who don't like it. Buy a bottle of it; it's not that expensive. Try it for yourself and see what you think.
I've used it frequently, but I often forget to apply it when it's most needed- when it's raining! You can't apply Rain-X on a wet vehicle. The glass surface and the rag you use to apply the stuff can't be wet.
For me the bottom line is this: If water sheets on the glass instead of beads up (even if it doesn't roll off), Rain-X helps. If you expect never to use your wipers after applying a coat of Rain-X, your expectations are too high.